This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [GOLD PATCH]: Support for some more options.
- From: Ian Lance Taylor <iant at google dot com>
- To: David Miller <davem at davemloft dot net>
- Cc: binutils at sourceware dot org
- Date: Wed, 16 Apr 2008 08:44:59 -0700
- Subject: Re: [GOLD PATCH]: Support for some more options.
- References: <20080416.001801.226057596.davem@davemloft.net>
David Miller <davem@davemloft.net> writes:
> + odyn->add_constant(elfcpp::DT_FLAGS_1, flags);
I think we should only emit DT_FLAGS_1 when flags != 0.
> + DEFINE_bool(initfirst, options::DASH_Z, '\0', false,
> + N_("Set DT_1_INITFIRST in DT_FLAGS_1 of shared object."),
> + NULL);
> + DEFINE_bool(interpose, options::DASH_Z, '\0', false,
> + N_("Set DT_1_INTERPOSE in DT_FLAGS_1 of output object."),
> + NULL);
> + DEFINE_bool(loadfltr, options::DASH_Z, '\0', false,
> + N_("Set DT_1_LOADFLTR in DT_FLAGS_1 of output object."),
> + NULL);
> + DEFINE_bool(nodefaultlib, options::DASH_Z, '\0', false,
> + N_("Set DT_1_NODEFLIB in DT_FLAGS_1 of output object."),
> + NULL);
> + DEFINE_bool(nodelete, options::DASH_Z, '\0', false,
> + N_("Set DT_1_NODELETE in DT_FLAGS_1 of output object."),
> + NULL);
> + DEFINE_bool(nodlopen, options::DASH_Z, '\0', false,
> + N_("Set DT_1_NOOPEN in DT_FLAGS_1 of output object."),
> + NULL);
> + DEFINE_bool(nodump, options::DASH_Z, '\0', false,
> + N_("Set DT_1_NODUMP in DT_FLAGS_1 of output object."),
> + NULL);
We can get better help messages here by copying the ones in
ld/emultempl/elf32.em, in the list_options function.
The patch is OK with those changes.
Thanks.
Ian