This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR ld/5789: Linker doesn't check weak and hidden symbols

From: "H.J. Lu" <hjl dot tools at gmail dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>, binutils at sourceware dot org
Date: Thu, 28 Feb 2008 07:02:57 -0800
Subject: Re: PATCH: PR ld/5789: Linker doesn't check weak and hidden symbols
References: <20080224001111.GA5967@lucon.org> <20080228083528.GA25964@bubble.grove.modra.org>

On Thu, Feb 28, 2008 at 12:35 AM, Alan Modra <amodra@bigpond.net.au> wrote:
> On Sat, Feb 23, 2008 at 04:11:11PM -0800, H.J. Lu wrote:
>  >       PR ld/5789
>  >       * elflink.c (_bfd_elf_symbol_refs_local_p): Always return true
>  >       for hidden and local symbols.
>
>  HJ, I think this part of your change is correct, but it breaks the ld
>  visibility tests.  Which means the tests are wrong and need fixing
>  too.
>

Hi Alan,

I tried it on Linux/ia32, Linux/Intel64 and Linux/ia64. There are no
testsuite failures in binutils.

H.J.

Follow-Ups:
- Re: PATCH: PR ld/5789: Linker doesn't check weak and hidden symbols
  - From: Alan Modra

References:
- PATCH: PR ld/5789: Linker doesn't check weak and hidden symbols
  - From: H.J. Lu
- Re: PATCH: PR ld/5789: Linker doesn't check weak and hidden symbols
  - From: Alan Modra

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]