This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] x86: fix register parsing and suffix recognition

>>> "H.J. Lu" <hjl.tools@gmail.com> 14.02.08 17:50 >>>
>On Thu, Feb 14, 2008 at 8:46 AM, Jan Beulich <jbeulich@novell.com> wrote:
>> >Don't we have ".att_syntax noprefix"? Can you add a testcase with it?
>>
>>  That would be redundant with the Intel test (as it would be testing the
>>  exact same code). I like tests, but I dislike useless duplication.
>>
>
>But they do have different syntaxes and go through different code paths.

No, parse_real_register() is used by both, and this is where it gets
decided whether or not a symbol is a register. I continue to not see
the value of a second test here, but I guess it'll take less time to copy
and slightly adjust the existing Intel test than to convince you...

Jan
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]