This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch bfd]: Add further support for x86_64 mingw
- From: Kai Tietz <Kai dot Tietz at onevision dot com>
- To: Brian Dessent <brian at dessent dot net>
- Cc: Binutils <binutils at sourceware dot org>
- Date: Tue, 22 Jan 2008 15:46:49 +0100
- Subject: Re: [patch bfd]: Add further support for x86_64 mingw
Brian Dessent wrote on 18.01.2008 00:56:15:
> Kai Tietz wrote:
>
> > +#ifndef _WIN32
> > #define sprintf_vma(s,x) sprintf (s, "%016llx", x)
> > #define fprintf_vma(f,x) fprintf (f, "%016llx", x)
> > #else
> > +#define sprintf_vma(s,x) sprintf (s, "%016I64x", x)
> > +#define fprintf_vma(f,x) fprintf (f, "%016I64x", x)
> > +#endif
> > +#else
>
> Can't you just use the standard inttypes.h macros, e.g.
>
> #define sprintf_vma(s,x) sprintf (s, "%016" PRIx64, x)
I could add the inttypes.h header into bfd-in.h, but this would mean to
inherit config, too. This I think isn't a good choice. So the other
solution to prevent to much target specific '#ifdef'-clauses would be to
add to bfd-in.h an equivalent to the printf formatters in standard
inttypes.h, like BFD_PRIx64, BFD_PRIx32, ...? Otherwise it seems to be
better to live with target specific clauses. What is your opinion about
this?
Kai
| (\_/) This is Bunny. Copy and paste Bunny
| (='.'=) into your signature to help him gain
| (")_(") world domination.
------------------------------------------------------------------------------------------
OneVision Software Entwicklungs GmbH & Co. KG
Dr.-Leo-Ritter-StraÃe 9 - 93049 Regensburg
Tel: +49.(0)941.78004.0 - Fax: +49.(0)941.78004.489 - www.OneVision.com
Commerzbank Regensburg - BLZ 750 400 62 - Konto 6011050
Handelsregister: HRA 6744, Amtsgericht Regensburg
KomplementÃrin: OneVision Software Entwicklungs Verwaltungs GmbH
Dr.-Leo-Ritter-StraÃe 9 â 93049 Regensburg
Handelsregister: HRB 8932, Amtsgericht Regensburg - GeschÃftsfÃhrer:
Ulrike DÃhler, Manuela Kluger