This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: makes --gc-sections compatible with -r/-q
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Tristan Gingold <gingold at adacore dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 9 Jan 2008 10:32:40 +1030
- Subject: Re: PATCH: makes --gc-sections compatible with -r/-q
- References: <C075C281-D6DA-4BD6-AE08-4155258B5F86@adacore.com>
On Tue, Jan 08, 2008 at 03:21:28PM +0100, Tristan Gingold wrote:
> this simple patch removes the incompatibility between --gc-sections
> and -r or -q.
> This feature is useful for VxWorks (whose loadable binaries are
> compiled with -r or -q) as well as
> for EFI modules.
>
> We (= AdaCore) are using it for a long time on VxWorks as we are
> compiling the Gnat run time with
> --gc-sections.
>
> This patch was test only for ppc-vxworks and i586-linux targets (on a
> i586-linux host).
Not just only tested on ppc and i586, but only written for ppc and
i586. Not OK without some more work.
You need to modify gc_sweep_hook to cope with -r for all targets.
Also, Eric's change, "Add missing guard", is not the proper fix for
ppc_elf_gc_sweep_hook. You should instead exit ppc_elf_gc_sweep_hook
immediately if -r, because that is what ppc_elf_check_relocs does.
--
Alan Modra
Australia Development Lab, IBM