This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Ping Re: Patch for MIPS multi-got bug with forced-local symbols
- From: Daniel Jacobowitz <drow at false dot org>
- To: binutils at sourceware dot org
- Cc: "Joseph S. Myers" <joseph at codesourcery dot com>
- Date: Mon, 8 Oct 2007 14:59:42 -0400
- Subject: Re: Ping Re: Patch for MIPS multi-got bug with forced-local symbols
- References: <Pine.LNX.4.64.0709191207020.26095@digraph.polyomino.org.uk> <Pine.LNX.4.64.0709261156230.24212@digraph.polyomino.org.uk> <Pine.LNX.4.64.0709282249490.7411@digraph.polyomino.org.uk> <20071006205539.GA28839@caradoc.them.org> <20071008133625.GA7117@caradoc.them.org>
On Mon, Oct 08, 2007 at 09:36:25AM -0400, Daniel Jacobowitz wrote:
> - else if (h->root.got.offset != 1)
> + else if (h->root.got.offset != 1 || h->root.forced_local)
That should be h->forced_local. The difference between these two
variables is confusing and there doesn't seem to be a clear
explanation of which is which; but h->forced_local means "has
been through the backend hide_symbol routine" which affects
accounting of GOT entries.
--
Daniel Jacobowitz
CodeSourcery