Re: PATCH: dynamically resize section merging hash tables.

["=?big5?b?RG91ZyBLd2FuICjD9q62vHcp?=" <dougkwan at google dot com>]

Hi Alan

2007/9/19, Alan Modra <amodra@bigpond.net.au>:

> I like this, but I think we can better split out the hash table
> resizing code as follows.

That's fine, as long as the performance problem is fixed.

merge.c 3 Jul 2007 14:26:42 -0000       1.32
> +++ bfd/merge.c 19 Sep 2007 09:20:25 -0000
> @@ -220,16 +220,11 @@ sec_merge_hash_lookup (struct sec_merge_
>      return NULL;
>
>    hashp = ((struct sec_merge_hash_entry *)
> -          sec_merge_hash_newfunc (NULL, &table->table, string));
> +          bfd_hash_insert (&table->table, string, hash));
>    if (hashp == NULL)

Formating nit: You may want to align the call to bfd_hash_insert with
the lines above and below.

Thanks for looking at my original patch and improving it. This will be
checked in not too far from now I guess?

-Doug