This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: bfd/elf32-bfin.c: Possible typo or cut/paste error?
> As far as I can tell, there is no such thing as R_BFIN_GOT12...
>
> 2007-09-04 Michael Snyder <msnyder@access-company.com>
>
> * elf32-bfin.c (howto_table): Cut and paste error?
> Name field of reloc is wrong.
And now that I think about it -- isn't the "bitsize" field
wrong too? Shouldn't it be 18?
And how about the "size" field? 1 = short? Isn't this field
supposed to be 18 bits? And isn't that too big for a short?
> Index: elf32-bfin.c
> ===================================================================
> RCS file: /cvs/src/src/bfd/elf32-bfin.c,v
> retrieving revision 1.22
> diff -c -8 -r1.22 elf32-bfin.c
> *** elf32-bfin.c 3 Jul 2007 14:26:40 -0000 1.22
> --- elf32-bfin.c 5 Sep 2007 00:50:15 -0000
> ***************
> *** 711,727 ****
> HOWTO (R_BFIN_GOT17M4, /* type */
> 2, /* rightshift */
> 1, /* size (0 = byte, 1 = short, 2 = long) */
> 16, /* bitsize */
> FALSE, /* pc_relative */
> 0, /* bitpos */
> complain_overflow_signed, /* complain_on_overflow */
> bfd_elf_generic_reloc, /* special_function */
> ! "R_BFIN_GOT12", /* name */
> FALSE, /* partial_inplace */
> 0xffff, /* src_mask */
> 0xffff, /* dst_mask */
> FALSE), /* pcrel_offset */
>
> /* The upper 16 bits of the GOT offset for the address of the
> symbol. */
> HOWTO (R_BFIN_GOTHI, /* type */
> --- 711,727 ----
> HOWTO (R_BFIN_GOT17M4, /* type */
> 2, /* rightshift */
> 1, /* size (0 = byte, 1 = short, 2 = long) */
> 16, /* bitsize */
> FALSE, /* pc_relative */
> 0, /* bitpos */
> complain_overflow_signed, /* complain_on_overflow */
> bfd_elf_generic_reloc, /* special_function */
> ! "R_BFIN_GOT17M4", /* name */
> FALSE, /* partial_inplace */
> 0xffff, /* src_mask */
> 0xffff, /* dst_mask */
> FALSE), /* pcrel_offset */
>
> /* The upper 16 bits of the GOT offset for the address of the
> symbol. */
> HOWTO (R_BFIN_GOTHI, /* type */
>
>