This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] coff-i386, guard against null

On Thu, Jul 26, 2007 at 07:41:39AM -0400, Daniel Jacobowitz wrote:
> On Wed, Jul 25, 2007 at 07:18:55PM -0700, H.J. Lu wrote:
> > On Wed, Jul 25, 2007 at 05:21:13PM -0700, msnyder@sonic.net wrote:
> > > Other code in this function checks to see if sym is null.
> > > If it's null here, it'll fail.
> > > 
> > 
> > > 2007-07-25  Michael Snyder  <msnyder@access-company.com>
> > > 
> > > 	* coff-i386.c (coff_i386_rtype_to_howto): Guard against null.
> > > 
> > 
> > I prefer BFD_ASSERT (sym != NULL).
> 
> BFD_ASSERT returns, though.

I'd like to know when this condition happens. Crash is better than
silent return.  That is how BFD_ASSERT is used other places.


H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]