This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [gprof] disjoint histograms


On Thu, Mar 15, 2007 at 03:58:52PM +0300, Vladimir Prus wrote:
> On Friday 23 February 2007 14:52, Daniel Jacobowitz wrote:
> > On Fri, Feb 23, 2007 at 11:15:50AM +0300, Vladimir Prus wrote:
> > > I certainly can update both NEWS and gprof.texi and post a new patch.
> > > I'll do that in a couple of days provided no objections to the
> > > code patch itself will show up.
> > 
> > It looks fine to me, except for two things: one "// FIXME" and two places
> > where you use malloc or realloc instead of xmalloc / xrealloc.  You
> > can also delete the casts of the malloc return value - now that we
> > assume c89 they're no longer necessary.
> 
> Here's a patch that addresses the above points, and adds
> a note to NEWS and modifies gprof.texi.
> 
> OK?

This is OK to commit.  Thanks for your patience.

-- 
Daniel Jacobowitz
CodeSourcery


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]