This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Move i386 opcode to opcodes/i386-opc.c

On Wed, Mar 21, 2007 at 03:45:12PM +0100, Andreas Schwab wrote:
> "H. J. Lu" <hjl@lucon.org> writes:
> 
> > On Wed, Mar 21, 2007 at 03:01:39PM +0100, Andreas Schwab wrote:
> >> "H. J. Lu" <hjl@lucon.org> writes:
> >> 
> >> > NOP_OPCODE is defined in opcode/i386.h.
> >> 
> >> But it still lacks a comment.
> >> 
> >
> > The opcode of nop instruction for x86 is 0x90. NOP_OPCODE shouldn't
> > be defined to something else.
> 
> The lack of a comment has already broken the assembler.
> 

opcode/i386.h should only cover x86 opcode. It should be independent
of assembler, disassembler and gdb.

BTW, do you have a testcase for this issue? I'd like to add it to
the testsuite.


H.J.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]