This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Move SYSV386_COMPAT to config/tc-i386.c


On Tue, Mar 13, 2007 at 05:33:01PM -0700, H. J. Lu wrote:
> On Wed, Mar 14, 2007 at 10:30:24AM +1030, Alan Modra wrote:
> > On Tue, Mar 13, 2007 at 10:50:42AM -0700, H. J. Lu wrote:
> > > 	(SystemV386): New.
> > > 	(Intel386): Likewise.
> > 
> > Why ever on earth do you need these?  Please don't add extra opcode
> > modifier bits unnecessarily.
> > 
> 
> I am planning to move i386.h to opcode/i386-opc.c and use bitfields
> instead.

I know you're planning that.

> SYSV386_COMPAT isn't very bitfield friendly.

Why not?  Can't you just use a different FloatDR macro?

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]