This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Remove --with-bugurl in gas, ld, gprof and binutils


On Wed, Mar 07, 2007 at 10:34:41PM +0000, Joseph S. Myers wrote:
> On Wed, 7 Mar 2007, H. J. Lu wrote:
> 
> > +	 echo "@set REPORT_BUGS_TO @uref{$(REPORT_BUGS_TO)}" | \
> > +	   sed -e "s/<URL://" -e "s/>//" >> doc/bfdver.texi
> 
> This doesn't allow for '@' characters in the URL (which seem by far the 
> most likely Texinfo metacharacters to appear there - someone could use a 
> mailto URL).  Since my patch does allow for them (and makes the necessary 
> changes to the manuals themselves), I think this illustrates why a patch 
> to use a common bfdver.texi should be based on a tree with my patch 
> already applied, or wait for my patch to be reviewed.

I think it should be the other way around. It doesn't make senses
to modify --with-bugurl in 3 places and remove them later.


H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]