This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] mips: Print extra elf header flags.
- From: Carlos O'Donell <carlos at codesourcery dot com>
- To: Hans-Peter Nilsson <hp at bitrange dot com>
- Cc: Nick Clifton <nickc at redhat dot com>, binutils at sourceware dot org, Richard Sandiford <richard at codesourcery dot com>
- Date: Fri, 16 Feb 2007 17:56:13 -0500
- Subject: Re: [PATCH] mips: Print extra elf header flags.
- References: <20070216151407.GR23930@lios> <Pine.BSF.4.58.0702161721580.17948@dair.pair.com>
On Fri, Feb 16, 2007 at 05:24:34PM -0500, Hans-Peter Nilsson wrote:
> On Fri, 16 Feb 2007, Carlos O'Donell wrote:
> > + if (elf_elfheader (abfd)->e_flags & EF_MIPS_NOREORDER)
> > + fprintf (file, _(" [.noreorder]"));
>
> I suggest you drop the _() on all these or else the translation
> team may be tempted to translate these strings to every
> (supported) human language. ;-)
I was blindly following the function convention, which uses _() for all
the output flags.
Is it a bad thing to mark all strings with _()? It's certainly an easier
rule than "Use your discretion" :-)
Cheers,
Carlos.
--
Carlos O'Donell
CodeSourcery
carlos@codesourcery.com
(650) 331-3385 x716