This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Re: Ld regressions on Linux/x86-64
On Mon, Feb 05, 2007 at 06:05:46PM -0500, Dave Brolley wrote:
> H. J. Lu wrote:
> >On Mon, Feb 05, 2007 at 12:51:06PM -0800, H. J. Lu wrote:
> >
> >>Hi Dave,
> >>
> >>Your checkins caused ld regressions on Linux/x86-64:
> >>
> >>FAIL: visibility (hidden_normal) (PIC main)
> >>FAIL: shared (PIC main)
> >>
> >>Have you seen them?
> >>
> >
> >I opened a bug report:
> >
> >http://sources.redhat.com/bugzilla/show_bug.cgi?id=3972
> >
> >
> I found the patch which corrects this problem. It was on an internal
> branch here at Red Hat and did not make it to the head of our repository
> from which I created my submission.
>
> OK to commit?
>
> BTW, I have never used the bugzilla system. What is the proper procedure
> after this patch has been approved and committed?
>
> Dave
> 2007-02-05 Dave Brolley <brolley@redhat.com>
>
> * Merge this change. The code is now in elflink.c.
> 2003-10-17 Stan Cox <scox@redhat.com>
>
> * elflink.h (elf_link_input_bfd): Always setup finfo->internal_syms.
>
I suggest you use
2007-02-05 Dave Brolley <brolley@redhat.com>
Stan Cox <scox@redhat.com>
PR ld/3972
* elflink.c (elf_link_input_bfd): Always setup finfo->internal_syms.
You can resolve PR after it has been committed and verified.
Thanks.
H.J.