This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] MIPS: Clean up gas help text.


Thiemo Seufer wrote:
David Daney wrote:
MIPS gas has redundant help text for the -mno-shared option. This patch tries to improve the situation.

Tested with x86_64-linux -> mipsel-linux cross build.

OK to commit?

2006-12-29 David Daney <ddaney@avtrex.com>

   * config/tc-mips.c (md_show_usage):  Clean up -mno-shared
   documentation.

David Daney

Index: config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.361
diff -c -p -r1.361 tc-mips.c
*** config/tc-mips.c 9 Nov 2006 13:04:39 -0000 1.361
--- config/tc-mips.c 30 Dec 2006 05:43:49 -0000
*************** MIPS options:\n\
*** 14832,14838 ****
-mfix-vr4130 work around VR4130 mflo/mfhi errata\n\
-mgp32 use 32-bit GPRs, regardless of the chosen ISA\n\
-mfp32 use 32-bit FPRs, regardless of the chosen ISA\n\
- -mno-shared optimize output for executables\n\
-msym32 assume all symbols have 32-bit values\n\
-O0 remove unneeded NOPs, do not swap branches\n\
-O remove unneeded NOPs and swap branches\n\
--- 14832,14837 ----
*************** MIPS options:\n\
*** 14846,14852 ****
-xgot assume a 32 bit GOT\n\
-mpdr, -mno-pdr enable/disable creation of .pdr sections\n\
-mshared, -mno-shared disable/enable .cpload optimization for\n\
! non-shared code\n\
-mabi=ABI create ABI conformant object file for:\n"));
first = 1;
--- 14845,14851 ----
-xgot assume a 32 bit GOT\n\
-mpdr, -mno-pdr enable/disable creation of .pdr sections\n\
-mshared, -mno-shared disable/enable .cpload optimization for\n\
! non position independent (non shared) code\n\

Ok, "position dependent" might sound better than "non position independent",
though.
OK, this is what I committed:
2007-01-03  David Daney  <ddaney@avtrex.com>

       * config/tc-mips.c (md_show_usage):  Clean up -mno-shared
       documentation.


Index: config/tc-mips.c
===================================================================
RCS file: /cvs/src/src/gas/config/tc-mips.c,v
retrieving revision 1.361
diff -u -p -r1.361 tc-mips.c
--- config/tc-mips.c	9 Nov 2006 13:04:39 -0000	1.361
+++ config/tc-mips.c	3 Jan 2007 18:04:24 -0000
@@ -14832,7 +14832,6 @@ MIPS options:\n\
 -mfix-vr4130		work around VR4130 mflo/mfhi errata\n\
 -mgp32			use 32-bit GPRs, regardless of the chosen ISA\n\
 -mfp32			use 32-bit FPRs, regardless of the chosen ISA\n\
--mno-shared		optimize output for executables\n\
 -msym32			assume all symbols have 32-bit values\n\
 -O0			remove unneeded NOPs, do not swap branches\n\
 -O			remove unneeded NOPs and swap branches\n\
@@ -14846,7 +14845,7 @@ MIPS options:\n\
 -xgot			assume a 32 bit GOT\n\
 -mpdr, -mno-pdr		enable/disable creation of .pdr sections\n\
 -mshared, -mno-shared   disable/enable .cpload optimization for\n\
-                        non-shared code\n\
+                        position dependent (non shared) code\n\
 -mabi=ABI		create ABI conformant object file for:\n"));
 
   first = 1;

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]