This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PATCH] PE direct linking to dlls, accept any filename.


> 
> This is exactly what happens when linking with the unpatched ld.
> Don't you have an ld.exe link/copy to ../../ld-new.exe in 
> /develop/cvs/binutils/build/ld/tmpdir/ld/ ?
> If there isn't one, then the one in the system will be picked up.
> Maybe I missed something in direct.exp?
> This is surelly a test bug, since my manual testing was successful
> once I copied ld-new.exe to tmpdir/ld/ld.exe.

Most be a bug, at least in my instantiation, of deja-gnu.
If I 'make install' newly built ld.exe, the test passes.   

So I withdraw my objection to the patch.

Could you add a test for symlinks (on cygwin), eg where libfoo.a is a
symlink to $PATH/foo.dll.
This is what 
       if (REALPATH (entry->filename, fbuf) == NULL)
		strncpy (fbuf, entry->filename, sizeof (fbuf));
is about I think.


Danny


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]