This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: PATCH: ld/3290: "ld -s" leaves absolute symbol in DSO
On Mon, Oct 16, 2006 at 01:53:30PM -0700, H. J. Lu wrote:
> On Sun, Oct 01, 2006 at 07:14:27AM -0700, H. J. Lu wrote:
> > On Fri, Sep 29, 2006 at 05:20:11PM -0700, H. J. Lu wrote:
> > > "gcc -g -feliminate-dwarf2-dups" may generate symbols relative to debug
> > > section. When "ld -s" removes debug section, it changes those symbols
> > > to absolute. The resulting shared library may not be usable. strip is
> > > even worse. When .debug_info section is removed, section index of
> > > debug symbol is totally wrong.
> > >
> > > This patch will hide debug symbols.
> > >
> > >
> >
> > Here is the updated patch to hide only definitions in debug sections.
> >
> >
>
> I added some testcases for this bug.
>
>
I added a test for "strip -s".
H.J.
---
bfd/
2006-10-16 H.J. Lu <hongjiu.lu@intel.com>
PR ld/3290
* elflink.c (elf_link_add_object_symbols): Hide definitions in
debug sections.
ld/testsuite/
2006-10-16 H.J. Lu <hongjiu.lu@intel.com>
PR ld/3290
* ld-elf/dummy.c: New file.
* ld-elf/dwarf.exp: Likewise.
* ld-elf/dwarf1.c: Likewise.
* ld-elf/dwarf1.h: Likewise.
* ld-elf/dwarf1.out: Likewise.
* ld-elf/dwarf1main.c: Likewise.
--- binutils/bfd/elflink.c.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/bfd/elflink.c 2006-10-16 18:16:29.000000000 -0700
@@ -4146,6 +4146,13 @@ elf_link_add_object_symbols (bfd *abfd,
dynsym = TRUE;
}
+ if (definition && (sec->flags & SEC_DEBUGGING))
+ {
+ /* We don't want to make debug symbol dynamic. */
+ (*bed->elf_backend_hide_symbol) (info, h, TRUE);
+ dynsym = FALSE;
+ }
+
/* Check to see if we need to add an indirect symbol for
the default name. */
if (definition || h->root.type == bfd_link_hash_common)
--- binutils/ld/testsuite/ld-elf/dummy.c.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/ld/testsuite/ld-elf/dummy.c 2006-10-16 13:43:48.000000000 -0700
@@ -0,0 +1 @@
+/* An empty file. */
--- binutils/ld/testsuite/ld-elf/dwarf.exp.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/ld/testsuite/ld-elf/dwarf.exp 2006-10-16 18:24:19.000000000 -0700
@@ -0,0 +1,111 @@
+# Expect script for various DWARF tests.
+# Copyright 2006 Free Software Foundation, Inc.
+#
+# This file is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, MA 02110-1301, USA.
+#
+
+#
+# Written by H.J. Lu (hongjiu.lu@intel.com)
+#
+
+# Exclude non-ELF targets.
+
+if ![is_elf_format] {
+ return
+}
+
+# The following tests require running the executable generated by ld.
+if ![isnative] {
+ return
+}
+
+# Check if compiler works
+if { [which $CC] == 0 } {
+ return
+}
+
+# Skip if -feliminate-dwarf2-dups isn't supported.
+if ![ld_compile "$CC -g -feliminate-dwarf2-dups" $srcdir/$subdir/dummy.c tmpdir/dummy.o] {
+ return
+}
+
+set build_tests {
+ {"Build libdwarf1.so"
+ "-s -shared" "-fPIC -g -feliminate-dwarf2-dups"
+ {dwarf1.c} {} "libdwarf1.so"}
+}
+
+set run_tests {
+ {"Run with libdwarf1.so first"
+ "tmpdir/libdwarf1.so" ""
+ {dwarf1main.c} "dwarf1a" "dwarf1.out"
+ "-g -feliminate-dwarf2-dups"}
+ {"Run with libdwarf1.so last"
+ "tmpdir/dwarf1main.o tmpdir/libdwarf1.so" ""
+ {dummy.c} "dwarf1b" "dwarf1.out"
+ "-g -feliminate-dwarf2-dups"}
+}
+
+run_cc_link_tests $build_tests
+run_ld_link_exec_tests [] $run_tests
+
+proc strip_test {} {
+ global ld
+ global strip
+ global NM
+
+ set test "libdwarf1c.so"
+ set test_name "Strip -s $test"
+ set prog $strip
+
+ if ![ld_simple_link $ld tmpdir/$test "-shared tmpdir/dwarf1.o"] {
+ unresolved "$test_name"
+ return
+ }
+
+ send_log "$NM -D tmpdir/$test > tmpdir/$test.exp\n"
+ catch "exec $NM -D tmpdir/$test > tmpdir/$test.exp" got
+ if ![string match "" $got] then {
+ send_log "$got\n"
+ unresolved "$test_name"
+ return
+ }
+
+ send_log "$prog -s tmpdir/$test\n"
+ catch "exec $prog -s tmpdir/$test" got
+ if ![string match "" $got] then {
+ send_log "$got\n"
+ fail "$test_name"
+ return
+ }
+
+ send_log "$NM -D tmpdir/$test > tmpdir/$test.out\n"
+ catch "exec $NM -D tmpdir/$test > tmpdir/$test.out" got
+ if ![string match "" $got] then {
+ send_log "$got\n"
+ unresolved "$test_name"
+ return
+ }
+
+ if { [catch {exec cmp tmpdir/$test.exp tmpdir/$test.out}] } then {
+ send_log "tmpdir/$test.exp tmpdir/$test.out differ.\n"
+ fail "$test_name"
+ return
+ }
+
+ pass "$test_name"
+}
+
+strip_test
--- binutils/ld/testsuite/ld-elf/dwarf1.c.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/ld/testsuite/ld-elf/dwarf1.c 2006-10-16 13:43:48.000000000 -0700
@@ -0,0 +1,10 @@
+#include <stdio.h>
+#include "dwarf1.h"
+
+struct foo_s foo;
+
+void
+doprintf (void)
+{
+ printf ("OK\n");
+}
--- binutils/ld/testsuite/ld-elf/dwarf1.h.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/ld/testsuite/ld-elf/dwarf1.h 2006-10-16 13:43:48.000000000 -0700
@@ -0,0 +1,6 @@
+struct foo_s
+{
+ int foo;
+};
+
+extern void doprintf (void);
--- binutils/ld/testsuite/ld-elf/dwarf1.out.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/ld/testsuite/ld-elf/dwarf1.out 2006-10-16 13:43:48.000000000 -0700
@@ -0,0 +1 @@
+OK
--- binutils/ld/testsuite/ld-elf/dwarf1main.c.dwarf 2006-10-16 13:43:48.000000000 -0700
+++ binutils/ld/testsuite/ld-elf/dwarf1main.c 2006-10-16 13:43:48.000000000 -0700
@@ -0,0 +1,10 @@
+#include "dwarf1.h"
+
+struct foo_s foo;
+
+int
+main (void)
+{
+ doprintf ();
+ return 0;
+}