This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
RE: [PATCH] Fix dlls for non underscored targets.
- From: Danny Smith <dannysmith at clear dot net dot nz>
- To: 'Pedro Alves' <pedro_alves at portugalmail dot pt>, binutils at sourceware dot org
- Date: Tue, 03 Oct 2006 21:36:39 +1300
- Subject: RE: [PATCH] Fix dlls for non underscored targets.
> -----Original Message-----
> From: binutils-owner@sourceware.org
> [mailto:binutils-owner@sourceware.org] On Behalf Of Pedro Alves
> Sent: Wednesday, 27 September 2006 1:33 a.m.
>
> 2006-09-25 Pedro Alves <pedro_alves@portugalmail.pt>
>
> ld/ChangeLog
>
> * pe-dll.c : Fix typo.
> (autofilter_symbolprefixlist) : Remove __imp_.
> (is_import) : New.
> (auto-export) : Remove re-import check. Moved to callers.
> (process_def_file) : Check is symbol is an import. Always
> underscore
> __imp_.
> Only skip underscore on underscored targets.
> (make_one) : Always underscore __imp_.
> (pe_create_runtime_relocator_reference) : Only underscore
> _pei386_runtime_relocator on underscored targets.
> (pe_process_import_defs) : Always underscore __imp_.
> * pe.em (U) : New macro.
> (set_pe_subsystem) : Remove underscore from _WinMainCRTStartup
> on wince subsystem case.
> (pe_find_data_imports) : Use U on "_head_".
> (gld_${EMULATION_NAME}_unrecognized_file) : Use U.
>
>
This causes no surprises in my tests on mingw-targeted dll's to date.
IMHO it should be installed.
Thanks Pedro
Danny