This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix dlls for non underscored targets.


Hi Danny,

Danny Smith wrote:

-----Original Message-----
From: Christopher Faylor


I'm also wondering if it would make sense to just put the "__imp_"/"_imp_"
string in a
variable somewhere and just use that.




Humm, not sure what you mean? With this patch it is __imp_

everywhere,


except one place (auto_export) that expects a symbol name

stripped from


the underscore. Maybe you meant a define?



I too think it would make sense to keep  char import_prefix[]
="__imp_"/"_imp_"  separate from the USER_LABEL_PREFIX. and just use
U(import_prefix) everywjhere.


That is exactly what my patch does, except for the U. Making your words mine, and tweaking a bit:

This patch makes import_prefix (="__imp_") separate from the USER_LABEL_PREFIX, and just use import_prefix everywhere.

Apart from that, the patch has  caused no surprises on testing with my
dll projects.


Forgot to say thanks for testing. Thanks.


Cheers,
Pedro Alves

Danny




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]