This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
[PATCH] Enable alignment test in ld-elfcomm/elfcomm.exp for MIPS
- From: Thiemo Seufer <ths at networkno dot de>
- To: binutils at sourceware dot org
- Date: Mon, 18 Sep 2006 15:45:09 +0100
- Subject: [PATCH] Enable alignment test in ld-elfcomm/elfcomm.exp for MIPS
Hello All,
I applied the appended patch, it enables the alignment warning test for
mips-*-* but keeps the size warning disabled.
Thiemo
2006-09-18 Thiemo Seufer <ths@networkno.de>
* ld-elfcomm/elfcomm.exp: Enable the alignment test for
mips*-*-*.
Index: ld/testsuite/ld-elfcomm/elfcomm.exp
===================================================================
RCS file: /cvs/src/src/ld/testsuite/ld-elfcomm/elfcomm.exp,v
retrieving revision 1.12
diff -u -p -r1.12 elfcomm.exp
--- ld/testsuite/ld-elfcomm/elfcomm.exp 16 Sep 2006 23:51:49 -0000 1.12
+++ ld/testsuite/ld-elfcomm/elfcomm.exp 18 Sep 2006 13:20:51 -0000
@@ -77,17 +77,22 @@ if { [ld_simple_link $ld tmpdir/common1.
return
}
-if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output]
- || ![regexp "Warning: size of symbol \`_?foo1\' changed from 2 in tmpdir/common1a.o to 21 in tmpdir/common1b.o" $link_output] } {
- if { [istarget mips*-*-*] } {
- # This test fails on MIPS because the backend sets type_change_ok. The
- # size change warning is suppressed.
- xfail $test1w1
+# This test fails on MIPS because the backend sets type_change_ok.
+# The size change warning is suppressed.
+if {[istarget mips*-*-*]} {
+ if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output] } {
+ fail $test1w1
} else {
- fail $test1w1
+ pass $test1w1
}
} else {
pass $test1w1
+ if { ![regexp "Warning: alignment (\[0-9\]+) of symbol \`_?foo1\' in tmpdir/common1b.o is smaller than 64 in tmpdir/common1a.o" $link_output]
+ || ![regexp "Warning: size of symbol \`_?foo1\' changed from 2 in tmpdir/common1a.o to 21 in tmpdir/common1b.o" $link_output] } {
+ fail $test1w1
+ } else {
+ pass $test1w1
+ }
}
if { [dump_common1 $test1c1] } {