This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [PATCH] Make the compiler do the math.
- From: Nick Clifton <nickc at redhat dot com>
- To: Pedro Alves <pedro_alves at portugalmail dot pt>
- Cc: binutils at sourceware dot org
- Date: Fri, 15 Sep 2006 10:46:15 +0100
- Subject: Re: [PATCH] Make the compiler do the math.
- References: <4505CCA5.2040301@portugalmail.pt> <45069956.302@portugalmail.pt>
Hi Pedro,
It seems I can't do anything right the first time. (Sigh...)
:-)
* pe-dll.c (AFET): New macro.
The name "AFET" is a little bit obscure. I would have thought a more
self-documenting name would be better, eg AUTOFILTER_ENTRY or
STRING_AND_LEN.
Also I think that it would be a great idea if this macro were placed in
a header file (eg bfd.h via bfd-in.h) so that it could be used elsewhere
in the binutils code (eg bfd/elf.c, bfd/archive.c, binutils/readelf.c).
In this case I think that a more generic name for the macro would be
appropriate (eg STRING_COMMA_LEN).
Cheers
Nick