This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] PREL_11_0 and PC12 Thumb-2 relocations


On Thu, 2006-08-31 at 16:06, Mark Shinwell wrote:
> Here is bfd support for the ARM Thumb-2 PREL_11_0 and PC12 relocs.
> At this stage gas support is not provided, but that is a QoI issue
> rather than an EABI-compliance issue.
> 
> Since gas support is lacking, this patch has been tested manually.
> Anyone who is interested can see the details of that testing below.
> 
> OK?
> 
Yes; however, is there some reason why this


> @@ -848,12 +848,12 @@ static reloc_howto_type elf32_arm_howto_
>  	 13,			/* bitsize */
>  	 TRUE,			/* pc_relative */
>  	 0,			/* bitpos */
> -	 complain_overflow_signed,/* complain_on_overflow */
> +	 complain_overflow_dont,/* complain_on_overflow */
>  	 bfd_elf_generic_reloc,	/* special_function */
>  	 "R_ARM_THM_PC12",	/* name */
>  	 FALSE,			/* partial_inplace */
> -	 0x040070ff,		/* src_mask */
> -	 0x040070ff,		/* dst_mask */
> +	 0x0fffffff,		/* src_mask */
> +	 0x0fffffff,		/* dst_mask */
>  	 TRUE),			/* pcrel_offset */

uses 0x_0_fffffff rather than 0x_f_fffffff ?

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]