This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: binutils-2.17: --cref broken? Extra warnings and corrupted data
On 7/16/06, Alan Modra <amodra@bigpond.net.au> wrote:
On Sat, Jul 15, 2006 at 11:41:23PM -0700, Paul Nash wrote:
> I determined with gdb that at the time add_cref is called,
> h->root.string is a valid string pointer. What's causing the problem
> is that later when the cref table is output, the underlying memory
> behind that pointer has been corrupted. In one case I looked at, a
> later bfd_zalloc call memset's all the memory around that string to 0.
Try reverting HJ's 2006-04-25 patch.
http://sources.redhat.com/ml/binutils/2006-04/msg00095.html
Please let us know if this fixes the problem for you. There are likely
to be other serious problems besides the --cref one.
Oops, I looked away for a day or two, sorry. Anyway, it sounds like
H.J. figured it out. Is the above referenced patch still suspect?
Should I try to remove that in general?
I'd be happy to verify any fixes you come up with, Alan.
Incidentally, I did test my theory of changing the "copy" flag to true
on cref hash table insertion, and that did appear to fix the problem,
but maybe that's just fixing a symptom, I don't know. Maybe there are
other places that also could be bitten by accessing invalid memory.
-PN