This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch] Arm BE8 stubs
- From: Nick Clifton <nickc at redhat dot com>
- To: Paul Brook <paul at codesourcery dot com>
- Cc: binutils at sourceware dot org
- Date: Wed, 24 May 2006 09:11:51 +0100
- Subject: Re: [patch] Arm BE8 stubs
- References: <200605182032.52425.paul@codesourcery.com>
Hi Paul,
2006-05-18 Paul Brook <paul@codesourcery.com>
* elf32-arm.c (put_arm_insn, put_thumb_insn): New functions.
(elf32_thumb_to_arm_stub, elf32_arm_to_thumb_stub,
elf32_arm_finish_dynamic_symbol): Use them.
Approved - please apply - but ...
+static void
+put_arm_insn(struct elf32_arm_link_hash_table *htab,
Formatting: There should be a space before the opening parenthesis.
+ bfd_putl32(val, ptr);
+ else
+ bfd_putb32(val, ptr);
Formatting again: More spaces before opening parentheses please.
(Similarly for put_thumb_insn as well).
Cheers
Nick