This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: [patch RFC] Fix PR binutils/2584
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- Cc: binutils at sources dot redhat dot com
- Date: Thu, 27 Apr 2006 11:50:13 +0930
- Subject: Re: [patch RFC] Fix PR binutils/2584
- References: <20060427.080623.74752937.kkojima@rr.iij4u.or.jp>
On Thu, Apr 27, 2006 at 08:06:23AM +0900, Kaz Kojima wrote:
> PR 2584
> * tekhex.c (first_phase): Change return type to bfd_boolean
> and return false if the unexpected character is found.
> (pass_over): Change return type to bfd_boolean and the type of
> the second argument to bfd_boolean (*) (bfd *, int, char *).
> Return false if FUNC returns false.
> (tekhex_object_p): Return NULL if pass_over fails.
Thanks, but can I ask that you do this differently? Add an
unsigned int * param to getsym to return the length, and move the hex
check into getsym. Return false from getsym on bad hex chars.
Similarly add a bfd_vma * param to getvalue to return the value and
return status via the function return. Also replace "abort ()" in
first_phase with "return FALSE" while you're at it. Patch preapproved.
--
Alan Modra
IBM OzLabs - Linux Technology Centre