This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Add support for ld-elf.so.hints on FreeBSD - Third try
- From: Nick Clifton <nickc at redhat dot com>
- To: Diego 'Flameeyes' Pettenò <flameeyes at gentoo dot org>
- Cc: binutils at sourceware dot org
- Date: Mon, 06 Mar 2006 16:22:27 +0000
- Subject: Re: Add support for ld-elf.so.hints on FreeBSD - Third try
- References: <200602271207.12967@enterprise.flameeyes.is-a-geek.org>
Hi Diego,
New version of the two patches to add support for ld hints on FreeBSD (and
DragonFly).
The patch is basically OK, but...
1. It is missing a ChangeLog entry.
2. Formatting - please follow the GNU Coding Convention:
+/*
+ * Read the system search path the FreeBSD way rather than like Linux.
+ */
should be:
/* Read the system search path the FreeBSD way rather then like
Linux. */
+ if (fread(&hdr, 1, sizeof(hdr), f) == sizeof(hdr) &&
should be:
if (fread (&hdr, 1, sizeof (hdr), f) == sizeof (hdr)
&& .....
3. License information:
+ * Fallback code taken from FreeBSD's libc
+ * Copyright (c) 1997 John D. Polstra.
Under what form(s) of license is this code distributed ? Is
it/are they compatible with the GPL ? Why have they not been included
here ?
4. What is this elf-hints.h file ? Shouldn't it be provided with the
patch ?
Cheers
Nick