Re: [PATCH / RFA] Add core file support functions to elf32-frv.c

[Nick Clifton <nickc at redhat dot com>]

Hi Kevin,

> Would a patch which eliminates PARAMS from this file (and perhaps others)
> be welcome? 
> (I have a script which does this.  It not only removes the
> PARAMS, but reindents the affected code.)

Oh most definitely.  Such patches, assuming that they make no other 
changes and that you have confirmed that the toolchain(s) affected still 
work can be considered to be pre-approved.

> +      /* The Linux/FRV elf_prstatus struct is 268 bytes long.  The other
> +         hardcoded offsets and sizes listed below (and contained within
> +	 this lexical block) refer to fields in the target's elf_prstatus
> +	 struct.  */

This is OK, although maybe you could use #defined names for the numbers 
so that, for example:

> +      case 268:	
> +	/* `pr_cursig' is at offset 12.  */
> +	elf_tdata (abfd)->core_signal = bfd_get_16 (abfd, note->descdata + 12);

could also be coded as:

         case 268:
#define PR_CURSIG 12 /* Offset of pr_cursig field in elf_prstatus 
struct.  The structure is not available here.  */
         elf_tdata (abfd)->core_signal =
           bfd_get_16 (abfd, note->descdata + PR_CURSIG);

Cheers
  Nick