Re: [PATCH / RFA] Add core file support functions to elf32-frv.c

[Nick Clifton <nickc at redhat dot com>]

Hi Kevin,

> 	* elf32-frv.c (elf32_frv_grok_prstatus, elf32_frv_grok_psinfo):
> 	New functions.
> 	* elf_backend_grok_prstatus, elf_backend_grok_psinfo): Define.

Please could you perform some small tidying up before committing this 
patch ?  Specifically:

> +static bfd_boolean elf32_frv_grok_prstatus
> +  PARAMS ((bfd *abfd, Elf_Internal_Note *note));
> +static bfd_boolean elf32_frv_grok_psinfo
> +  PARAMS ((bfd *abfd, Elf_Internal_Note *note));

We no longer need the PARAMS macro.  We are use ISO C now.

> +	/* pr_cursig */

Comment formating.  Should be /* pr_cursig.  */

> +	/* pr_pid */

Likewise.

> +	elf_tdata (abfd)->core_pid = bfd_get_32 (abfd, note->descdata + 24);

Just a query - is there any way to make the value of "24" more 
explanatory ?  Is it the offset of a known field in a structure which 
you could get with offsetof() for example ?

> +      case 124:		/* Linux/FRV elf_prpsinfo */

More comment formatting.

With these changes applied your patch is approved - please commit.

Cheers
  Nick