This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
Re: Patch/PE-COFF: Provide default suffix to NAME or LIBRARY names in .def files
- From: Christopher Faylor <me at cgf dot cx>
- To: dannysmith at users dot sourceforge dot net, binutils <binutils at sources dot redhat dot com>
- Date: Tue, 31 Jan 2006 21:30:03 -0500
- Subject: Re: Patch/PE-COFF: Provide default suffix to NAME or LIBRARY names in .def files
- References: <20060201004028.22622.qmail@web50905.mail.yahoo.com>
On Wed, Feb 01, 2006 at 01:40:28PM +1300, Danny Smith wrote:
>ChangeLog
>
>2006-02-01 Danny Smith <dannysmith@users.sourceforge.net>
>
> * deffilep.y (def_image_name): If the image name does not have a
> suffix, append the default.
> *ld.texinfo: Document NAME, LIBRARY usage in PE-COFF .def files.
Just a minor nit.
>! memcpy (def->name + len, is_dll ? ".dll\0" : ".exe\0", 5);
I don't see any reason for an explicit \0 in the above case. That's
a given. Was this just to make it clear where the fifth character was
coming from in the copy?
Also, on some architectures, I believe that strcpy would be faster
than memcpy for this operation. Does using memcpy buy us anything here?
cgf