This is the mail archive of the
binutils@sourceware.org
mailing list for the binutils project.
fix uninitialized values in Xtensa PIC code
- From: Bob Wilson <bwilson at tensilica dot com>
- To: binutils at sources dot redhat dot com
- Date: Wed, 25 Jan 2006 21:30:35 -0800
- Subject: fix uninitialized values in Xtensa PIC code
I recently discovered that the md_apply_fix function in the Xtensa
port of GAS has been failing to "apply" any value at all for
XTENSA_PLT relocations, leading to uninitialized data in the output.
This shows up clearly with valgrind but is apparently harmless in
many cases, perhaps because the data is usually zero. It did cause
one real failure for a program in the GCC testsuite. The patch
changes the function to always set the value to something, with a
default of zero. Tested and committed on the mainline.
2006-01-25 Bob Wilson <bob.wilson@acm.org>
* config/tc-xtensa.c (md_apply_fix): Set value to zero for
PLT relocs.
Attachment:
gas-plt-rel.diff
Description: Binary data