This is the mail archive of the binutils@sourceware.org mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Fix gas/1948 -- Duplicate .comm symbols


On Sun, Dec 04, 2005 at 01:21:58PM -0500, John David Anglin wrote:
> --- symbols.c	17 Nov 2005 07:29:28 -0000	1.71
> +++ symbols.c	3 Dec 2005 22:18:09 -0000
> @@ -376,6 +376,9 @@ colon (/* Just seen "x:" - rattle symbol
>  		    && S_IS_EXTERNAL (symbolP))
>  		   || S_GET_SEGMENT (symbolP) == bss_section)
>  		  && (now_seg == data_section
> +#if defined (TC_HPPA) && !(defined (OBJ_ELF) && (defined (TE_LINUX) || defined (TE_NetBSD)))
> +		      || now_seg == bss_section
> +#endif
>  		      || now_seg == S_GET_SEGMENT (symbolP)))
>  		{
>  		  /* Select which of the 2 cases this is.  */

I don't think you need the #if.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]