This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: bfd/elf/mn10300 "dangerous error"
- From: Ian Lance Taylor <ian at airs dot com>
- To: DJ Delorie <dj at redhat dot com>
- Cc: binutils at sources dot redhat dot com
- Date: 18 Jul 2005 12:39:18 -0700
- Subject: Re: bfd/elf/mn10300 "dangerous error"
- References: <200507181935.j6IJZRsS007971@greed.delorie.com>
DJ Delorie <dj@redhat.com> writes:
> in elf-m10300.c we have code like this:
>
> case bfd_reloc_dangerous:
> msg = _("internal error: dangerous error");
> goto common_error;
>
> common_error:
> if (!((*info->callbacks->warning)
> (info, msg, name, input_bfd, input_section,
> rel->r_offset)))
> return FALSE;
> break;
>
> Why doesn't bfd_reloc_dangerous invoke the dangerous_reloc callback?
> The way it is now, dangerous relocs let the linker succeed, because
> they're only warnings.
The notion of what dangerous means is target dependent. Some
dangerous relocs should only be warnings. Some should be fatal
errors. I don't know which is the case for elf-m10300.c.
Ian