This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

PATCH: Remove Intel PNI/VMX suffix check


The 'i' suffix check was added to PNI_Fixup in

http://sourceware.org/ml/binutils/2004-06/msg00421.html

Alan, do you remember why it is needed? I am going to check in this
patch to remove it unless there is a testcase to show the suffix check
is needed.

H.J.
On Mon, Jul 18, 2005 at 09:19:31AM -0600, Jan Beulich wrote:
> You appearantly copied the code from PNI_Fixup, which deals with sidt.
> The 'i' is the second letter, but for you this second letter is 'g'. And
> no, I don't have a testcase, I just saw this when I glanced through your
> patch. Jan
> 
> >>> "H. J. Lu" <hjl@lucon.org> 18.07.05 16:32:21 >>>
> On Mon, Jul 18, 2005 at 02:04:55AM -0600, Jan Beulich wrote:
> > In VMX_Fixup:
> > 
> > >+      /* We might have a suffix.  */
> > >+      if (*p == 'i')
> > >+	--p;
> > 
> > I think this needs to be
> > 
> >       /* We might have a suffix.  */
> >       if (*p == 'g')
> > 	--p;
> 
> Where does it come from? Is that for Intel mode? Do you have a
> testcase?
> 
> 
> H.J.

Attachment: opcodes-i386-fixup-1.patch
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]