This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: fix dwarf2 handling of signed addresses

On Fri, Jul 08, 2005 at 09:02:09AM -0700, Eric Christopher wrote:
> > 2005-07-08  Paul Koning  <pkoning@equallogic.com>
> > 
> > 	* dwarf2.c (read_address): Check sign_extend_vma to handle targets
> > 	where addresses are sign extended.
> 
> My only reservation for this is that we should be sign extending every
> address no matter what and that this points to a bug in our code
> elsewhere.

Are you sure?  Remember, many targets zero extend - Paul's patch looks
sensible to me.

FWIW GDB has many of the same problems.  That's why GDB still doesn't
use DWARF-2 unwinding on MIPS; someone needs to take another stab at
that.

-- 
Daniel Jacobowitz
CodeSourcery, LLC
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]