This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Patch for binutils configure cleanup
- From: James E Wilson <wilson at specifixinc dot com>
- To: sje at cup dot hp dot com
- Cc: binutils at sourceware dot org
- Date: Thu, 30 Jun 2005 20:24:15 -0700
- Subject: Re: Patch for binutils configure cleanup
- References: <200506301640.JAA20386@hpsje.cup.hp.com>
On Thu, 2005-06-30 at 09:40, Steve Ellcey wrote:
> * configure.in (AM_BINUTILS_WARNINGS): Add.
> (BFD_NEED_DECLARATION): Replace with AC_CHECK_DECLS.
> * configure: Regenerate.
> * config.in: Regenerate.
> * objdump.c (NEED_DECLARATION_*): Replace with !HAVE_DECL_*.
> * bucomm.h: (NEED_DECLARATION_*): Ditto.
Yes, this is OK. And you can check this in yourself now, which saves me
the trouble of having to mess with autoconf and regenerate the stuff you
(correctly) did not include.
I believe this is the last remaining use of BFD_NEED_DECLARATION, which
means we should be removing it from bfd/bfd.m4 now. Please submit a
patch for that to complete this change.
Optionally, if you want some more busy work to do, there is the related
GAS_CHECK_DECL_NEEDED macro in gas/acinclude.m4 that probably isn't need
anymore. Getting rid of this one may be a bit more work as you will
have to figure out exactly what it is doing.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com