This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: hppa build broken
- From: "John David Anglin" <dave at hiauly1 dot hia dot nrc dot ca>
- To: sje at cup dot hp dot com (Steve Ellcey)
- Cc: binutils at sources dot redhat dot com, amodra at bigpond dot net dot au
- Date: Wed, 15 Jun 2005 19:19:09 -0400 (EDT)
- Subject: Re: hppa build broken
> ! if (extra > 0)
I believe that the above can be changed to
if (extra > 0 || bcount == 0)
> ! {
> ! char *p = frag_var (rs_fill, extra, extra, 0, NULL, 1, NULL);
> ! memset (p, 0, extra);
> ! }
and the following code deleted.
> ! if (bcount == 0 && extra == 0)
> ! {
> ! char *p = frag_var (rs_fill, 1, 1, 0, NULL, 0, NULL);
> ! memset (p, 0, 1);
> ! }
It's ok to call memset with extra == 0. This should duplicate the
behavior prior to Alan's change. Need to check that
.block 0
actually produces a 0 sized block. I'll try this when I get home
tonight.
Dave
--
J. David Anglin dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada (613) 990-0752 (FAX: 952-6602)