This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH]: Fix compile time warning building ARM port of GAS


Nick Clifton <nickc@redhat.com> writes:

>>>Sorry, that's not a redundant test.  Look farther down the file, each
>>>of the Txx macros has a corresponding non-T macro, that invokes the T
>>> macro with 0 for the 'te' argument.  
>
> OK, in which case we need to fix this non-T macros.  What do you think
> of the attached patch ?

Looks good to me, except I would prefer the use of 0 rather than NULL,
for consistency with the rest of the file.

>>>I can work with you to find another solution, but I'm not seeing these
>>>warnings.  What compiler are you using?
>
> I am using a 3.4 based version distributed by RedHat to some of our
> customers:

Ah.  I'm using 3.3 (Debian's default).  Now I think about it, this
warning was only added in 3.4.

zw


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]