This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] ia64: ensure unwind records' t coordinate gets set
- From: James E Wilson <wilson at specifixinc dot com>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 25 May 2005 12:10:51 -0700
- Subject: Re: [PATCH] ia64: ensure unwind records' t coordinate gets set
- References: <s293dcc1.080@lucius.provo.novell.com>
On Wed, 2005-05-25 at 01:02, Jan Beulich wrote:
> I didn't apply this, yet. Instead, I'd like to apply the following
> revised patch. However, I didn't change the comment you said was wrong,
> because I didn't understand what you think is wrong with it.
The comment says that we are only setting slot numbers for unwind
records belonging to the current insn. However, if the next insn has no
unwind records, and a subsequent ones does, then we are actually setting
slot numbers all of the unwind records. Hence the comment is wrong, or
at least misleading. This misleading comment could confuse someone into
thinking that the first instance of this code is unnecessarily complex
and needs to be fixed.
Deleting the second assignment to end_ptr solves this problem. Now the
code matches the comment.
This is OK.
--
Jim Wilson, GNU Tools Support, http://www.SpecifixInc.com