This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] PR 878: fix -pie
On Fri, May 06, 2005 at 05:34:25PM -0700, H. J. Lu wrote:
> On Sat, May 07, 2005 at 09:42:20AM +0930, Alan Modra wrote:
> > On Fri, May 06, 2005 at 08:42:19AM -0700, H. J. Lu wrote:
> > > - if (!link_info.relocatable && !link_info.shared)
> > > + if (link_info.executable)
> >
> > Why did you remove the relocatable test?
> >
>
> I didn't realize that we set link_info.executable for -r. How about
> this patch?
>
>
> H.J.
> ---
> 2005-05-06 H.J. Lu <hongjiu.lu@intel.com>
>
> * ldmain.c (main): Set link_info.executable to TRUE only if
> link_info.relocatable isn't.
I'd rather you just put back the link_info.relocatable test. Your patch
might be OK, but I'd guess that you haven't audited all places that test
link_info.executable.
--
Alan Modra
IBM OzLabs - Linux Technology Centre