This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Fix make -jN in bfd/doc
- From: Daniel Jacobowitz <drow at false dot org>
- To: Gwenole Beauchesne <gbeauchesne at mandriva dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Fri, 6 May 2005 09:15:55 -0400
- Subject: Re: [PATCH] Fix make -jN in bfd/doc
- References: <Pine.LNX.4.58.0505061112240.13659@thalys.mandrakesoft.com>
On Fri, May 06, 2005 at 11:23:31AM +0200, Gwenole Beauchesne wrote:
> Hi,
>
> This patch fixes make -jN (tested with N = 4) in bfd/doc. Otherwise,
> multiple gccs were disputing chew paternity.
>
> 2005-04-30 Gwenole Beauchesne <gbeauchesne@mandriva.com>
>
> * bfd/doc/Makefile.am: Fix dependencies on chew for parallel build.
> * bfd/doc/Makefile.in: Regenerate.
This patch is incorrect, since the whole point was to not have the texi
files depend on the built chew. It sounds like we need to use a
temporary file to build chew and move it into place atomically.
>
> --- binutils-2.16.90.0.2/bfd/doc/Makefile.in.bfd-make-chew 2005-04-29 19:50:26.000000000 +0200
> +++ binutils-2.16.90.0.2/bfd/doc/Makefile.in 2005-04-30 07:04:56.227212000 +0200
> @@ -604,115 +604,93 @@ $(srcdir)/bfd.info bfd.dvi: $(DOCFILES)
> # program. If somebody tries to rebuild info, but none of the .texi files
> # have changed, then nothing will be rebuilt.
>
> -aoutx.texi: chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
> - $(MAKE) $(MKDOC)
> +aoutx.texi: $(MKDOC) chew.c $(srcdir)/../aoutx.h $(srcdir)/doc.str
> ./$(MKDOC) -f $(srcdir)/doc.str <$(srcdir)/../aoutx.h >aoutx.tmp
> $(SHELL) $(srcdir)/../../move-if-change aoutx.tmp aoutx.texi
--
Daniel Jacobowitz
CodeSourcery, LLC