This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[patch] Missing R_ARM_PLT32 cases


The attached patch fixes a couple of places where we should be treating 
R_ARM_PLT32 the same as R_ARM_PC24, but don't. The the first was causing 
failures in the g++ testsuite.

Tested on arm-none-gnueabi.
Applied to binutils-csl-arm-2005q1-branch
Ok for mainline?

Paul

2005-05-01  Paul Brook  <paul@codesourcery.com>

	* elf32-arm.c (bfd_elf32_arm_process_before_allocation): Treat
	R_ARM_PLT32 the same as R_ARM_PC24.
	(arm_add_to_rel): Ditto.
Index: bfd/elf32-arm.c
===================================================================
RCS file: /var/cvsroot/src-cvs/src/bfd/elf32-arm.c,v
retrieving revision 1.22.2.3.2.6
diff -u -p -r1.22.2.3.2.6 elf32-arm.c
--- bfd/elf32-arm.c	26 Apr 2005 05:31:38 -0000	1.22.2.3.2.6
+++ bfd/elf32-arm.c	1 May 2005 22:51:40 -0000
@@ -2393,6 +2393,7 @@ bfd_elf32_arm_process_before_allocation 
 	  switch (r_type)
 	    {
 	    case R_ARM_PC24:
+	    case R_ARM_PLT32:
 #ifndef OLD_ARM_ABI
 	    case R_ARM_CALL:
 	    case R_ARM_JUMP24:
@@ -2413,7 +2414,7 @@ bfd_elf32_arm_process_before_allocation 
 	      break;
 
 	    default:
-	      break;
+	      abort ();
 	    }
 	}
 
@@ -3993,6 +3994,7 @@ arm_add_to_rel (bfd *              abfd,
 	  break;
 
 	case R_ARM_PC24:
+	case R_ARM_PLT32:
 #ifndef OLD_ARM_ABI
 	case R_ARM_CALL:
 	case R_ARM_JUMP24:

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]