This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] i386: cr8 handling
- From: Alan Modra <amodra at bigpond dot net dot au>
- To: Jan Beulich <JBeulich at novell dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 2 Mar 2005 08:37:05 +1030
- Subject: Re: [PATCH] i386: cr8 handling
- References: <s22479f8.048@emea1-mh.id2.novell.com>
On Tue, Mar 01, 2005 at 03:20:04PM +0100, Jan Beulich wrote:
> Also, I'd think it should be
> && (r->reg_type != Control || !(cpu_arch_flags &
> CpuSledgehammer))
Yes, I meant to write "== 0" rather than "!= 0".
> Please let me know if you indeed want me to add this additional check.
Yes, I think the test is worth having.
> Why? CpuUnknownFlags contains CpuSledgehammer, so it should be enabled
> by default.
Right. Too late at night when I reviewed.
--
Alan Modra
IBM OzLabs - Linux Technology Centre