This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Additional TC_EQUAL_IN_INSN check

From: Nick Clifton <nickc at redhat dot com>
To: clm at cm00re dot com
Cc: binutils at sourceware dot org
Date: Wed, 16 Feb 2005 12:22:12 +0000
Subject: Re: [PATCH] Additional TC_EQUAL_IN_INSN check
References: <200502151337.j1FDb4u2012330@mx3.redhat.com>

Hi Catherine,

This patch adds an argument to TC_EQUAL_IN_INSN so that the current string
can be checked.

Why is this needed ? Do you have a port where the current semantics for TC_EQUAL_IN_INSN are insufficient ? [The string 's' can be deduced from input_line_pointer, so why pass it as an extra argument ?]

It also adds an additional check for TC_EQUAL_IN_INSN in read_a_source_file.

Again - why is is this necessary ? Couldn't the if-statement be rearranged so that there was only one invocation of TC_EQUAL_IN_INSN ?

Cheers
  Nick

Follow-Ups:
- RE: [PATCH] Additional TC_EQUAL_IN_INSN check
  - From: Catherine Moore

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]