This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: [PATCH] Indicate dependency on personality routines for ARM EHABI
- From: Julian Brown <julian at codesourcery dot com>
- To: Ian Lance Taylor <ian at airs dot com>
- Cc: binutils at sources dot redhat dot com
- Date: Wed, 09 Feb 2005 17:09:28 +0000
- Subject: Re: [PATCH] Indicate dependency on personality routines for ARM EHABI
- References: <420A38B6.3010609@codesourcery.com> <m3hdkllmme.fsf@gossamer.airs.com>
Ian Lance Taylor wrote:
Julian Brown <julian@codesourcery.com> writes:
/* These relocs are only used within the ARM assembler. They are not
(at present) written to any object files. */
+ BFD_RELOC_ARM_NONE,
Why not just use BFD_RELOC_NONE here?
In general you should only create a target specific BFD_RELOC enum
constant for relocations which only arise on a particular target. For
example, note that there is no BFD_ARM_RELOC_32.
Perhaps it should be, and I tried it with that initially. The reason it
isn't is because elsewhere in tc-arm.c:md_apply_fix3 BFD_RELOC_NONE
seems to be used as an error indicator:-
case BFD_RELOC_NONE:
default:
as_bad_where (fixP->fx_file, fixP->fx_line,
_("bad relocation fixup type (%d)"), fixP->fx_r_type);
...which was being triggered when that relocation type was requested
with fix_new(), I think. Is there another way around that?
Cheers,
Julian
--
Julian Brown
CodeSourcery, LLC