This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Indicate dependency on personality routines for ARMEHABI


On Wed, 2005-02-09 at 16:22, Julian Brown wrote:
> Hi,
> 
> This patch causes gas to emit dependencies on personality routines 
> (__aeabi_unwind_cpp_pr[012]) from a suitable run-time library when 
> necessary, using an R_ARM_NONE relocation type.
> 
> Tested on i686-pc-linux-gnu and arm-none-eabi with no regressions 
> (though the expected output for the .ARM.extab has changed for one of 
> the tests.)
> 
> OK to apply?
>
> ChangeLog:
> 
>      * bfd/bfd-in2.h (bfd_reloc_code_real): New relocation type
>      (BFD_RELOC_ARM_NONE).
>      * bfd/elf32-arm.c (elf32_arm_reloc_map): BFD_RELOC_ARM_NONE maps to
>      R_ARM_NONE.
>      * bfd/libbfd.h (bfd_reloc_code_): Add BFD_RELOC_ARM_NONE.
>      * bfd/reloc.c (BFD_RELOC_ARM_NONE): Add.
>      * gas/config/tc-arm.c (md_apply_fix3): Handle BFD_RELOC_ARM_NONE.
>      (tc_gen_reloc): Handle BFD_RELOC_ARM_NONE.
>      (create_unwind_entry): Output dependency on the unwinding routines.
>      * gas/testsuite/gas/arm/unwind.d: Alter expected output to include
>      dependency on __aeabi_unwind_cpp_pr[01].


bfd-in2.h is a generated file.  Rather than your above ChangeLog entry
you should just log it as regenerated.

It's not necessary to include patches to generated files when sending a
changeset, just note that it has been rebuilt.

OK apart from that.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]