This is the mail archive of the binutils@sources.redhat.com mailing list for the binutils project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Indicate dependency on personality routines for ARM EHABI


Julian Brown <julian@codesourcery.com> writes:

>   /* These relocs are only used within the ARM assembler.  They are not
>   (at present) written to any object files.  */
> +   BFD_RELOC_ARM_NONE,

Why not just use BFD_RELOC_NONE here?

In general you should only create a target specific BFD_RELOC enum
constant for relocations which only arise on a particular target.  For
example, note that there is no BFD_ARM_RELOC_32.

More generally, I think it's kind of dubious to use a zero reloc to
mean anything at all.  And why do you need a relocation entry?  Why is
it not sufficient to enter the symbol in the symbol table as an
undefined symbol?  Is the use of a zero reloc mandated by the ARM ABI?

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]