This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Fix for gas/elf/section5.[els]
- From: Nick Clifton <nickc at redhat dot com>
- To: jbeulich at novell dot com
- Cc: binutils at sources dot redhat dot com
- Date: Mon, 20 Dec 2004 15:41:42 +0000
- Subject: Fix for gas/elf/section5.[els]
Hi Jan,
I am going to apply the attached patch to fix a small problem with
your recent addition of the section5 test to the gas/elf testsuite.
The problem was that it uses the @ character to introduce the type
of the sections, but for the ARM port this is a
start-of-line-comment character... Fortunately binutils is set up
to treat the % character in the same way as the @ character in
.section declarations so all my patch does is to make this switch.
Cheers
Nick
gas/testsuite/ChangeLog
2004-12-20 Nick Clifton <nickc@redhat.com>
* gas/elf/section5.[ls]: Use % instead of @ in .section
directives.
Index: gas/testsuite/gas/elf/section5.l
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section5.l,v
retrieving revision 1.1
diff -c -3 -p -r1.1 section5.l
*** gas/testsuite/gas/elf/section5.l 16 Dec 2004 13:23:22 -0000 1.1
--- gas/testsuite/gas/elf/section5.l 20 Dec 2004 15:31:40 -0000
***************
*** 12,29 ****
[ ]+[[:digit:]]+[ ]+.section[ ]+.test0[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test1,[ ]*"",[ ]*@progbits[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test2[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test3,[ ]*"aw"[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test4,[ ]*"aw",[ ]*@nobits[ ]*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test1,[ ]*"aw",[ ]*@nobits[ ]*
[ ]+[[:digit:]]+[ ]+.*
[ ]+[[:digit:]]+[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test2,[ ]*"w"[ ]*
[ ]+[[:digit:]]+[ ]+.*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test3,[ ]*"aw",[ ]*@progbits[ ]*
[ ]+[[:digit:]]+[ ]+.*
[ ]+[[:digit:]]+[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test4,[ ]*"aw"[ ]*
--- 12,29 ----
[ ]+[[:digit:]]+[ ]+.section[ ]+.test0[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test1,[ ]*"",[ ]*%progbits[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test2[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test3,[ ]*"aw"[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test4,[ ]*"aw",[ ]*%nobits[ ]*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test1,[ ]*"aw",[ ]*%nobits[ ]*
[ ]+[[:digit:]]+[ ]+.*
[ ]+[[:digit:]]+[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test2,[ ]*"w"[ ]*
[ ]+[[:digit:]]+[ ]+.*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.test3,[ ]*"aw",[ ]*%progbits[ ]*
[ ]+[[:digit:]]+[ ]+.*
[ ]+[[:digit:]]+[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.test4,[ ]*"aw"[ ]*
***************
*** 32,37 ****
[ ]+[[:digit:]]+[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.bss,[ ]*"a"[ ]*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.data,[ ]*"aw",[ ]*@nobits[ ]*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.bss,[ ]*"aw",[ ]*@progbits[ ]*
--- 32,37 ----
[ ]+[[:digit:]]+[ ]*
[ ]+[[:digit:]]+[ ]+.section[ ]+.bss,[ ]*"a"[ ]*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.data,[ ]*"aw",[ ]*%nobits[ ]*
[ ]+[[:digit:]]+[ ]*
! [ ]+[[:digit:]]+[ ]+.section[ ]+.bss,[ ]*"aw",[ ]*%progbits[ ]*
Index: gas/testsuite/gas/elf/section5.s
===================================================================
RCS file: /cvs/src/src/gas/testsuite/gas/elf/section5.s,v
retrieving revision 1.1
diff -c -3 -p -r1.1 section5.s
*** gas/testsuite/gas/elf/section5.s 16 Dec 2004 13:23:22 -0000 1.1
--- gas/testsuite/gas/elf/section5.s 20 Dec 2004 15:31:40 -0000
***************
*** 1,16 ****
.section .test0
! .section .test1, "", @progbits
.section .test2
.section .test3, "aw"
! .section .test4, "aw", @nobits
! .section .test1, "aw", @nobits
test1: .long test1
.section .test2, "w"
test2: .long test2
! .section .test3, "aw", @progbits
test3: .long test3
.section .test4, "aw"
--- 1,16 ----
.section .test0
! .section .test1, "", %progbits
.section .test2
.section .test3, "aw"
! .section .test4, "aw", %nobits
! .section .test1, "aw", %nobits
test1: .long test1
.section .test2, "w"
test2: .long test2
! .section .test3, "aw", %progbits
test3: .long test3
.section .test4, "aw"
*************** test3: .long test3
*** 19,24 ****
.section .bss, "a"
! .section .data, "aw", @nobits
! .section .bss, "aw", @progbits
--- 19,24 ----
.section .bss, "a"
! .section .data, "aw", %nobits
! .section .bss, "aw", %progbits