This is the mail archive of the
binutils@sources.redhat.com
mailing list for the binutils project.
Re: Increment size of relax sequence if we emit a nop
- From: Richard Sandiford <rsandifo at redhat dot com>
- To: Ian Lance Taylor <ian at wasabisystems dot com>
- Cc: binutils at sourceware dot org
- Date: Thu, 09 Dec 2004 16:38:08 +0000
- Subject: Re: Increment size of relax sequence if we emit a nop
- References: <20041209155111.10502.qmail@gossamer.airs.com>
Ian Lance Taylor <ian@wasabisystems.com> writes:
> Index: config/tc-mips.c
> ===================================================================
> RCS file: /cvs/src/src/gas/config/tc-mips.c,v
> retrieving revision 1.275
> diff -u -r1.275 tc-mips.c
> --- config/tc-mips.c 9 Dec 2004 06:17:14 -0000 1.275
> +++ config/tc-mips.c 9 Dec 2004 15:47:41 -0000
> @@ -2542,6 +2542,8 @@
> instruction at the destination, put it in the delay
> slot, and bump the destination address. */
> emit_nop ();
> + if (mips_relax.sequence)
> + mips_relax.sizes[mips_relax.sequence - 1] += 4;
> /* Update the previous insn information. */
> prev_prev_insn = *ip;
> prev_insn.insn_mo = &dummy_opcode;
Wouldn't it be better to turn emit_nop() into a function and do this
check there instead? It's the kind of thing that might be needed in
more than one place otherwise.
Richard