Re: [PATCH] Fix strings to work with > 2GB files again on 32-bit arches

[Alan Modra <amodra at bigpond dot net dot au>]

On Tue, Oct 12, 2004 at 01:49:06AM -0400, Jakub Jelinek wrote:
> On Tue, Oct 12, 2004 at 08:45:06AM +0930, Alan Modra wrote:
> > What about all the other uses of get_file_size?  Shouldn't you be fixing
> > get_file_size instead?
> 
> All the other tools work with object files and handling there
> > 2GB files would require more changes than just get_file_size.
> strings works on all files and is ATM the only one using fopen64/etc.

I see.

> Plus I really think strings should work also on devices, which get_file_size
> refuses and it should work also on zero length files, which get_file_size
> doesn't like either.

Yes.  OK, I'm willing to pre-approve a patch to do that as well.

-- 
Alan Modra
IBM OzLabs - Linux Technology Centre